fixes, clean up, and new ideas #6

Open
liberate_on_chain wants to merge 43 commits from liberate_on_chain/ronindojo:develop into develop
No description provided.
Author
Owner

Format guidelines have been proposed in commit f568eeb637 please review and inform if acceptable or needs modification

The same has been done in RoninOS repo in commit e5f59c8daef8be2fe83163919640dc22545b64bd

Format guidelines have been proposed in commit f568eeb6371e243d322b222889692c4bc1673196 please review and inform if acceptable or needs modification The same has been done in RoninOS repo in commit e5f59c8daef8be2fe83163919640dc22545b64bd
Author
Owner

Offtopic: after I was given email, changed my email, and now shows as "signed by untrusted user" for commits

I hope this will not cause a problem on the merge

Offtopic: after I was given email, changed my email, and now shows as "signed by untrusted user" for commits I hope this will not cause a problem on the merge
Author
Owner

Please respond to my pgp key inquiries in DM I would like to propose an updating of this general infrastructure thank you

Please respond to my pgp key inquiries in DM I would like to propose an updating of this general infrastructure thank you
Owner
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

The maintainer(s) and admins of the open source software project
known as RoninDojo have created a new PGP key:
pgp@ronindojo.io
4D8C CBBE FAE5 AC5B 8BC1  130B 1165 73F8 7BD3 EDF7

This PGP key will from now on be used to sign software releases,
warrant canary and other messages.
This message is signed with previous PGP key:
admin@ronindojo.io
5886 DB12 27CD C975 BD19  E3E3 2E3B 7B27 FAAA E324

Today is 2025-06-27.
Latest bitcoin block hash:
0000000000000000000178276538634a47641eaa2e9e57310e05d507c075527e
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEWIbbEifNyXW9GePjLjt7J/qq4yQFAmheseIACgkQLjt7J/qq
4ySopgwAuz4aiyG0c+OSNqk6tBRgjMlJTleHaph+eRFzO2qyqWMPHOA/BE5pcVgN
NXX2Ra7czDkiT7blY1MBg5p1/AECUym77AA/rpcNSyc4VGIk6DX9JD7dreRuueL3
JgkBXI6zleuKhU1wQUZbtvxi8a1SxSwmZK9Wvsl8cAGGK8hXEhEtzMaW8BZgWTtZ
tw0m382sSpK79Ue0+YEMbqO1tUmghD/LRC57bXgfYorbG07HmRDb4zqLbHW6j4MS
nNPDyCN7aIHaJqlo98Ane9N78YVIX/8KorluM+yRuHjhP3TrZQ+Ap/8WTtOTyCNv
hCw4sdE6abh7N8xBhfxMhbNW/OfCQKkSEGVzt9PYCHFSbi+/mlMljVB3dY8IM+6C
YmitojVwp48IxD8AeEXC2oSeU9yypPzcPX5nMKcUVSTtB8hDVWkQZQFC7WhdWnxp
v2vJNJjkQOPCFteyCI5QqgkX6/54erhcTrwSkpJ3mM1b3fTIR/bWyykfo835aA+b
F2c+Ui5Y
=ujAg
-----END PGP SIGNATURE-----
``` -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 The maintainer(s) and admins of the open source software project known as RoninDojo have created a new PGP key: pgp@ronindojo.io 4D8C CBBE FAE5 AC5B 8BC1  130B 1165 73F8 7BD3 EDF7 This PGP key will from now on be used to sign software releases, warrant canary and other messages. This message is signed with previous PGP key: admin@ronindojo.io 5886 DB12 27CD C975 BD19  E3E3 2E3B 7B27 FAAA E324 Today is 2025-06-27. Latest bitcoin block hash: 0000000000000000000178276538634a47641eaa2e9e57310e05d507c075527e -----BEGIN PGP SIGNATURE----- iQGzBAEBCAAdFiEEWIbbEifNyXW9GePjLjt7J/qq4yQFAmheseIACgkQLjt7J/qq 4ySopgwAuz4aiyG0c+OSNqk6tBRgjMlJTleHaph+eRFzO2qyqWMPHOA/BE5pcVgN NXX2Ra7czDkiT7blY1MBg5p1/AECUym77AA/rpcNSyc4VGIk6DX9JD7dreRuueL3 JgkBXI6zleuKhU1wQUZbtvxi8a1SxSwmZK9Wvsl8cAGGK8hXEhEtzMaW8BZgWTtZ tw0m382sSpK79Ue0+YEMbqO1tUmghD/LRC57bXgfYorbG07HmRDb4zqLbHW6j4MS nNPDyCN7aIHaJqlo98Ane9N78YVIX/8KorluM+yRuHjhP3TrZQ+Ap/8WTtOTyCNv hCw4sdE6abh7N8xBhfxMhbNW/OfCQKkSEGVzt9PYCHFSbi+/mlMljVB3dY8IM+6C YmitojVwp48IxD8AeEXC2oSeU9yypPzcPX5nMKcUVSTtB8hDVWkQZQFC7WhdWnxp v2vJNJjkQOPCFteyCI5QqgkX6/54erhcTrwSkpJ3mM1b3fTIR/bWyykfo835aA+b F2c+Ui5Y =ujAg -----END PGP SIGNATURE----- ```
Member

Comments given out of band, otherwise progress thus far ACK.

Comments given out of band, otherwise progress thus far ACK.
Author
Owner

looks like fa83de2df4 fixed the tput error I have seen

looks like fa83de2df4fbdef22584c15c7a0725ebb11d5af1 fixed the tput error I have seen
Author
Owner

the last commit marks the finish of a big reorganization that will help with x86 support

the last commit marks the finish of a big reorganization that will help with x86 support
liberate_on_chain changed title from WIP: fixes, clean up, and new ideas to fixes, clean up, and new ideas 2025-07-04 03:13:15 +00:00
Author
Owner

ready for review, please go to Ronin/RoninOS#2 (comment) for instructions on building an image and testing

ready for review, please go to http://2l2o5umijiwxjioxwpsvwxe6pr75tj7r5rggnl5ze256guwvtee3kpqd.onion/Ronin/RoninOS/pulls/2#issuecomment-169 for instructions on building an image and testing
Member

Changes made regarding the scripts for the ronin systemd unit file for networking, started in 68e23ef7ad, will require an update script to facilitate migrating existing users.

This request to change is of course pending the decision for whether or not this PR regards making RoninDojo 2.2 forwards incompatible, i.e. considering this to be a 3.0.

Regarding the changes that would be required for a migration: the unit file that exists on current users their systems refer to old file location A of the networking script. The changes of this PR move the networking script to new location B, as well as changing how the unit file would now be freshly made such that it refers to new location B works for new users. If existing users are to migrate with an update instead of a reflash, their system's existing unit file would have to be replaced with the new one referring to location B and the service to be reloaded and restarted.

Changes made regarding the scripts for the ronin systemd unit file for networking, started in 68e23ef7adb0f3501180d7faf007c6a7f8bc4612, will require an update script to facilitate migrating existing users. This request to change is of course pending the decision for whether or not this PR regards making RoninDojo 2.2 forwards incompatible, i.e. considering this to be a 3.0. Regarding the changes that would be required for a migration: the unit file that exists on current users their systems refer to old file location A of the networking script. The changes of this PR move the networking script to new location B, as well as changing how the unit file would now be freshly made such that it refers to new location B works for new users. If existing users are to migrate with an update instead of a reflash, their system's existing unit file would have to be replaced with the new one referring to location B and the service to be reloaded and restarted.
@ -0,0 +13,4 @@
# shellcheck source=./scripts/functions/functions-gpio.sh
. "${RONIN_USER_HOME}/ronindojo/scripts/functions/functions-gpio.sh"
# shellcheck source=./scripts/functions/functions-gpio.sh

Please fix the shellcheck sourcing directive to refer to the corresponding file for the line of code that follows it.

Please fix the shellcheck sourcing directive to refer to the corresponding file for the line of code that follows it.
liberate_on_chain marked this conversation as resolved
@ -0,0 +35,4 @@
##############
# Detect and set storage variable
_setup_storage_config

Nice find to facilitate for the users who only have to run install-dojo.sh and not precedingly install-system-setup.sh

Nice find to facilitate for the users who only have to run install-dojo.sh and not precedingly install-system-setup.sh
NullFireFear marked this conversation as resolved
Author
Owner

another note I see my commits are marked as "signed by untrusted user" because I changed email in the middle of this open PR but did not change PGP key

when creating a test PR and doing commit I see that the commits are marked as trusted so this issue should not persist in any future PRs

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

this is a message to prove I am still in control of the original liberate_on_chain PGP key

the only change made was migrating to new email

sorry for any confusion
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE3qMbSAdiEaotkV2UmSZaanCDyp8FAmiBKBNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldERF
QTMxQjQ4MDc2MjExQUEyRDkxNUQ5NDk5MjY1QTZBNzA4M0NBOUYACgkQmSZaanCD
yp99dQ/+IDgvxs3+ULHAhHIq733+UGqFHbQr9QNXi3MKrFULlMkrPnpV1hgnp0xh
MwOSwcSqwf8koOB9i7YfsKpiDK4uUA9YrNNdCctgAdZAxxnrV62glgb2JGBYmaI1
a/IORfhP95y1RoLF7DiY61GWwyj/smOyiXTktA6YbRAouSNLNnYj92h8ZtJzLgG7
HD6Ns+kr9olcBvVubDJwpkKAdXPDCXWIF7Sr4ojc6fDtuvLjo1wXZwFFOp+Slj3K
13vLBTWm3+KNV4XKf+omzJ5rFeWYsiLjNgERO1S3pOeVABCBlOIlXgy3dDb1u5C3
K+wleyotNvXsKl4rrB3i0fmxcVOEo95702heFntmDiJ94G+hmU0lceHpATEDA6UW
25L3hiCF4EIjSd7dlWEUcrrfd/Gv8n7odhh+hpC45l4kNU8unEn16x87adcPDwor
FRuEEqdlwz9DYwjus592eRmmELPaHIi4RDuywIhvO98f/KD/m62bDi72N1bBCSxI
vxWidCB/2GbxNnuQICCDBiuPYyHFIT/5DOEs5y9KGPQldLVANUTbhVngZ8R5FocI
j/2dI4caef69HHd3xZB3ZxHQ48Z8ul+IMwbaWmQA8wZNv4Nd4OW9XxYg0MWyIYLW
7RG45llmDrI0lv5EYxrth0mBer6GAJ+w4MAd3wNTvBtkjYtWWe4=
=930c
-----END PGP SIGNATURE-----
another note I see my commits are marked as "signed by untrusted user" because I changed email in the middle of this open PR but did not change PGP key when creating a test PR and doing commit I see that the commits are marked as trusted so this issue should not persist in any future PRs ``` -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 this is a message to prove I am still in control of the original liberate_on_chain PGP key the only change made was migrating to new email sorry for any confusion -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE3qMbSAdiEaotkV2UmSZaanCDyp8FAmiBKBNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldERF QTMxQjQ4MDc2MjExQUEyRDkxNUQ5NDk5MjY1QTZBNzA4M0NBOUYACgkQmSZaanCD yp99dQ/+IDgvxs3+ULHAhHIq733+UGqFHbQr9QNXi3MKrFULlMkrPnpV1hgnp0xh MwOSwcSqwf8koOB9i7YfsKpiDK4uUA9YrNNdCctgAdZAxxnrV62glgb2JGBYmaI1 a/IORfhP95y1RoLF7DiY61GWwyj/smOyiXTktA6YbRAouSNLNnYj92h8ZtJzLgG7 HD6Ns+kr9olcBvVubDJwpkKAdXPDCXWIF7Sr4ojc6fDtuvLjo1wXZwFFOp+Slj3K 13vLBTWm3+KNV4XKf+omzJ5rFeWYsiLjNgERO1S3pOeVABCBlOIlXgy3dDb1u5C3 K+wleyotNvXsKl4rrB3i0fmxcVOEo95702heFntmDiJ94G+hmU0lceHpATEDA6UW 25L3hiCF4EIjSd7dlWEUcrrfd/Gv8n7odhh+hpC45l4kNU8unEn16x87adcPDwor FRuEEqdlwz9DYwjus592eRmmELPaHIi4RDuywIhvO98f/KD/m62bDi72N1bBCSxI vxWidCB/2GbxNnuQICCDBiuPYyHFIT/5DOEs5y9KGPQldLVANUTbhVngZ8R5FocI j/2dI4caef69HHd3xZB3ZxHQ48Z8ul+IMwbaWmQA8wZNv4Nd4OW9XxYg0MWyIYLW 7RG45llmDrI0lv5EYxrth0mBer6GAJ+w4MAd3wNTvBtkjYtWWe4= =930c -----END PGP SIGNATURE----- ```
Commenting is not possible because the repository is archived.
No labels
No milestone
No project
No assignees
3 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Ronin/ronindojo!6
No description provided.