fixes, clean up, and new ideas #6
Loading…
Reference in a new issue
No description provided.
Delete branch "liberate_on_chain/ronindojo:develop"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Format guidelines have been proposed in commit
f568eeb637please review and inform if acceptable or needs modificationThe same has been done in RoninOS repo in commit e5f59c8daef8be2fe83163919640dc22545b64bd
Offtopic: after I was given email, changed my email, and now shows as "signed by untrusted user" for commits
I hope this will not cause a problem on the merge
Please respond to my pgp key inquiries in DM I would like to propose an updating of this general infrastructure thank you
f568eeb637, modify all global variables to uppercase, modify all local variables to lowercase, remove leading underscore from any local variable, improved readability e586ef5873Comments given out of band, otherwise progress thus far ACK.
f568eeb637, fix typos 47f6b445c3looks like
fa83de2df4fixed the tput error I have seenthe last commit marks the finish of a big reorganization that will help with x86 support
WIP: fixes, clean up, and new ideasto fixes, clean up, and new ideasready for review, please go to Ronin/RoninOS#2 (comment) for instructions on building an image and testing
Changes made regarding the scripts for the ronin systemd unit file for networking, started in
68e23ef7ad, will require an update script to facilitate migrating existing users.This request to change is of course pending the decision for whether or not this PR regards making RoninDojo 2.2 forwards incompatible, i.e. considering this to be a 3.0.
Regarding the changes that would be required for a migration: the unit file that exists on current users their systems refer to old file location A of the networking script. The changes of this PR move the networking script to new location B, as well as changing how the unit file would now be freshly made such that it refers to new location B works for new users. If existing users are to migrate with an update instead of a reflash, their system's existing unit file would have to be replaced with the new one referring to location B and the service to be reloaded and restarted.
@ -0,0 +13,4 @@# shellcheck source=./scripts/functions/functions-gpio.sh. "${RONIN_USER_HOME}/ronindojo/scripts/functions/functions-gpio.sh"# shellcheck source=./scripts/functions/functions-gpio.shPlease fix the shellcheck sourcing directive to refer to the corresponding file for the line of code that follows it.
@ -0,0 +35,4 @@############### Detect and set storage variable_setup_storage_configNice find to facilitate for the users who only have to run install-dojo.sh and not precedingly install-system-setup.sh
another note I see my commits are marked as "signed by untrusted user" because I changed email in the middle of this open PR but did not change PGP key
when creating a test PR and doing commit I see that the commits are marked as trusted so this issue should not persist in any future PRs