Ronin/dojo
Archived
Watch
8
1
Fork
You've already forked dojo
 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

WIP: Release v2.3.0 #4

Draft
dojocoder wants to merge 0 commits from release/v2.3.0 into master
pull from: release/v2.3.0
merge into: Ronin:master
Conversation 1 Commits - Files changed -
dojocoder commented 2025-06-30 17:54:09 +00:00
Owner
Copy link
No description provided. 
v1.18.0 v1.18.0
v1.18.1 v1.18.1
Tagging version 1.19.0 v1.19.0
Tagging hotfix 1.19.1 v1.19.1
Tagging version 1.19.2 v1.19.2
Tagging version 1.20.0 v1.20.0
Tagging version 1.21.0 v1.21.0
Tagging version 1.22.0 v1.22.0
Tagging version 1.23.0 v1.23.0
Tagging version 1.24.0 v1.24.0
Tagging hotfix 1.24.1 v1.24.1
Tagging version 1.25.0 v1.25.0
Tagging version 1.26.0 v1.26.0
Tagging version 1.26.1 v1.26.1
Add instructions to migrate blockchain/fulcrum, fix link
* Add new /support/services RPC endpoint

* Adapt structure of JSON returned by /support/services

* Remove fallback to OXT when local explorer isn't installed

* Update doc/GET_support_services.md
# Conflicts:
#	.eslintrc.json
#	RELEASES.md
#	accounts/index.js
#	accounts/seen-rest-api.js
#	db-scripts/2_update.sql.tpl
#	doc/DOCKER_setup.md
#	doc/DOCKER_synology_setup.md
#	doc/DOCKER_ubuntu_setup.md
#	docker/my-dojo/.env
#	docker/my-dojo/bitcoin/Dockerfile
#	docker/my-dojo/bitcoin/ban-knots.sh
#	docker/my-dojo/bitcoin/restart.sh
#	docker/my-dojo/conf/docker-bitcoind.conf.tpl
#	docker/my-dojo/conf/docker-node.conf.tpl
#	docker/my-dojo/dojo.sh
#	docker/my-dojo/explorer/Dockerfile
#	docker/my-dojo/fulcrum/Dockerfile
#	docker/my-dojo/indexer/Dockerfile
#	docker/my-dojo/install/install-scripts.sh
#	docker/my-dojo/install/upgrade-scripts.sh
#	docker/my-dojo/node/keys.index.js
#	docker/my-dojo/tor/Dockerfile
#	docker/my-dojo/tor/restart.sh
#	keys/index-example.js
#	lib/auth/auth-rest-api.js
#	lib/auth/authentication-manager.js
#	package-lock.json
#	package.json
#	static/admin/lib/api-wrapper.js
#	tracker/transaction.js
dojocoder force-pushed release/v2.3.0 from 1fccee04f2 to a4888b3812 2025-06-30 18:08:46 +00:00 Compare
NullFireFear requested changes 2025-07-06 10:45:20 +00:00
NullFireFear left a comment

Other changes are all ACK

Other changes are all ACK
docker/my-dojo/bitcoin/restart.sh Outdated
@ -40,9 +40,13 @@ if [ "$BITCOIND_PERSIST_MEMPOOL" == "on" ]; then
bitcoind_options+=(-persistmempool=1)
fi
if [ "$BITCOIND_PERSIST_MEMPOOL" == "on" ]; then
NullFireFear commented 2025-07-06 10:23:31 +00:00
Member

This if-block of code is already present right above it.

This if-block of code is already present right above it.
dojocoder commented 2025-07-06 14:34:59 +00:00
Author
Owner

Fixed

Fixed
dojocoder marked this conversation as resolved
docker/my-dojo/bitcoin/restart.sh Outdated
@ -51,13 +55,28 @@ if [ "$BITCOIND_RPC_EXTERNAL" == "on" ]; then
bitcoind_options+=(-zmqpubrawblock=tcp://0.0.0.0:9503)
fi
if [ "$BITCOIND_BLOOM_FILTERS" == "on" ]; then
NullFireFear commented 2025-07-06 10:24:33 +00:00
Member

This if-block of code activating peerbloomfilters is a regression.

This if-block of code activating peerbloomfilters is a regression.
dojocoder commented 2025-07-06 14:34:46 +00:00
Author
Owner

Fixed

Fixed
dojocoder marked this conversation as resolved
docker/my-dojo/conf/docker-bitcoind.conf.tpl
@ -25,3 +25,3 @@
# Number of threads to service RPC calls
# Type: integer
BITCOIND_RPC_THREADS=12
BITCOIND_RPC_THREADS=16
NullFireFear commented 2025-07-06 10:27:23 +00:00
Member

This number deviated from upstream before, was this number already optimized for SBC's? Are there new findings regarding the effect of this parameter for SBC's?

This number deviated from upstream before, was this number already optimized for SBC's? Are there new findings regarding the effect of this parameter for SBC's?
dojocoder commented 2025-07-06 14:31:18 +00:00
Author
Owner

Bitcoin Core v29 has raised the default to 16 threads so it seemed like a good idea to have it at 16 by default as well. RockPro64 has 6 cores (2 high-performance and 4 energy-efficient). Even on low-end devices like Raspi 4, the default setting should be at least double the count of CPU cores because some threads might be idle due to I/O and other reasons. With Dojo, indexer and explorer using RPC, I think it makes sense to raise this limit a bit. This change will not be applied for users who are upgrading, only for new installations.

Bitcoin Core v29 has raised the default to 16 threads so it seemed like a good idea to have it at 16 by default as well. RockPro64 has 6 cores (2 high-performance and 4 energy-efficient). Even on low-end devices like Raspi 4, the default setting should be at least double the count of CPU cores because some threads might be idle due to I/O and other reasons. With Dojo, indexer and explorer using RPC, I think it makes sense to raise this limit a bit. This change will not be applied for users who are upgrading, only for new installations.
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
NullFireFear
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Ronin/dojo!4
No description provided.