RoninOS docker builds #2
Loading…
Reference in a new issue
No description provided.
Delete branch ":develop"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Getting docker builds working...
According to latest commit: set BUILD_DOCKER=no if a native build is desired on ARM instead of docker build on x86
my apologies for the comment mixup on previous commit
05e9957a55, fixed in next commit1576af1589WIP: RoninOS docker buildsto RoninOS docker buildsPlease run
./build-roninos.shand inform resultsThe defaults.sh file should be set to
When the
customize-image.shscript is ran in build process, I do see errorSo far I assume this error is related to hostname in the chroot-like environment that mimics the target system
Build logs as of latest commit
https://paste.armbian.com/ejunajohol
Please alter clone_armbian() such that
Please alter build-roninos.sh such that
ok latest commit
26fbd946bfshould addresse5f59c8dae), add print_print_message() and _print_error_message() functions, fix _mark_setup() function to correct line so it is successfully called, fix sed command 8758baef93Updated testing directions below and fastest method is to open clean VM that is Windows Subsystem Linux (WSL in Windows app store), Ubuntu 24.04 Noble, or Debian 12 Bookworm
nano /$HOME/RoninOS/defaults.shto edit thedefaults.shscript to modify build variables@ -0,0 +34,4 @@fi# Run initial x86 or ARM setup then stop script and inform user to reboot to apply changesif [[ "${ARCH}" == "x86_64" ]]; thenThere is some amount of overlap in the procedures implemented in the functions _setup_x86 and _setup_arm.
Is it possible to structure this sequence as a standardized procedure, where only the deviations are present in the CPU architecture specific functions?
An example would be:
Any further standardization of the procedure can be done at your own discretion (i.e. nothing at all, or as much as you want).
@ -0,0 +91,4 @@_print_message "The tor service is running..."else_print_error_message "The tor service is NOT running..."exit 1please use "return 1" instead of "exit 1" for functions that merely indicate a true/false situation (as the function name indicates).
Otherwise, any function that is intentionally to stop the current shell's execution based on such a check, should explicitly use the word "assert" in the function name to indicate that the script is to not continue at all if the check fails. Example function name: _assert_is_tor_running
added above comments to my list, will attempt to resolve these comments as soon as possible
currently the builds are going good after latest commit, new options are now available
updated testing instructions!
try using an x86 virtual machine to do the build like debian 12, and run these commands to clone repo:
please try any of the following:
the defaults.sh file should be set to:
New changes ACK.
Approval pending previous comments having been processed in new changes.
RoninOS docker buildsto WIP: RoninOS docker buildsChanged target branch to feature/docker-builds
Edit changed back to develop as target for time being. Ideally we would use a feature branch for this.
Once testing complete:
This is very helpful.
I believe this resolves all pending previous comments @NullFireFear and will begin final testing for release
another note I see my commits are marked as "signed by untrusted user" because I changed email in the middle of this open PR but did not change PGP key
when creating a test PR and doing commit I see that the commits are marked as trusted so this issue should not persist in any future PRs
completed work and final tests pass for this RoninOS release please review and merge into main develop branch when ready thank you
WIP: RoninOS docker buildsto RoninOS docker builds